Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ISSUE-371: do not compare backLen > 0 #580

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix ISSUE-371: do not compare backLen > 0 #580

wants to merge 1 commit into from

Conversation

FallenAngel666
Copy link

Instead we just look if backLen is set.
More infos here: #371

Q A
Bug fix? yes
New feature? no
Doc update? no
BC breaks? no
Deprecations? no
Fixed tickets #371

@FallenAngel666
fix ISSUE-371: do not compare backLen > 0
cd53f8a 
Instead we just look if backLen is set. 
More infos here: miguelbalboa#371
Rotzbua
Rotzbua requested changes May 21, 2022
View reviewed changes
Copy link
Collaborator

@Rotzbua Rotzbua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems not right.

A check

if (backData && backLen) {

makes no sense if pointer is accessed before by

byte totalBackLen = *backLen;

@Rotzbua Rotzbua added the need_review ↩️ awaiting review from people (before merge) label May 21, 2022
tueddy added a commit to tueddy/rfid that referenced this pull request Mar 4, 2024
@tueddy
fix ISSUE-371: do not compare backLen > 0 miguelbalboa#580
caa3e6d 
miguelbalboa#580
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rotzbua Rotzbua Rotzbua requested changes

Assignees
No one assigned
Labels
need_review ↩️ awaiting review from people (before merge)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FallenAngel666 @Rotzbua @oxg4113